MTG Salvation

This is a pretty fair magic card. Love that it gives card advantage if your hand is low and rewards you for pitching cards like Phoenix.

I'm not really sure this is better than Young Pyromancer. The most you can get out of it is 4 tokens. YP has no limit.

If your hand's empty, you get a Divination instead.

In a world where fair decks take over Modern, this is pretty cool. For the moment, it is at least interesting. 1RR isn't optimal, but it's also right in the sweet spot for shenanigans with Bloodbraid Elf and Collected Company, et al. Having a way to cash in value post-mortem is a nice bonus.

How would this work with madness? Would it still count alms if the vein as a non-land card and give you a token or revert to not give you anything because you didn’t discard it?

As far as I am aware you would still meet the clause of discarding a non land card(s).

Q1) Did you discard two cards? Yes.
Q2) Were the cards non land? Yes.

Create you creature tokens.

The fact you got to play those cards for their madness cost should not matter because that is an ability and in order to pay for that ability you must have discarded said card(s).